-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce 6.0 release branch CI runs (6.0 preview 2) #49169
Reduce 6.0 release branch CI runs (6.0 preview 2) #49169
Conversation
Change dotnet#41856 reduced stress job frequency to once per day, alternating between main and the release branches. However, the release branches get few changes yet still run the job. (Also, all the release branches run the job at the same time.) Change to running the job daily in main, where most development happens. Also change the runs to daily in the release branches, but change to only run if the branch has changed since the last run.
Tagging subscribers to this area: @hoyosjs Issue Details6.0 release branches are running AzDO stress pipelines on a schedule, even though (normally) nothing is changing. Change this to only run if something changes. This is a port of #49020 to the release branch.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit.
- cron: "0 4 * * 1,3,5" | ||
displayName: Mon, Wed, Fri at 8:00 PM (UTC-8:00) | ||
- cron: "0 4 * * *" | ||
displayName: Daily at 8:00 PM (UTC-8:00) | ||
branches: | ||
include: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master no longer exists, I'd revert these lines of the change as this will only after the branch you check it in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we could just delete the "master" section of this (and other) yml files, since they're unused in the release branches anyway.
I did this just as a "cherry-pick" from the 'main' branch change, so it doesn't really hurt, either
We should hold off on this. I believe the last runtime change for p2 has left the station |
@mmitche the issue here is that this is an infra-only change. The 6.0p1 and 6.0p2 branches continue to run these pipelines 4 times per week, and I want them to stop (unless needed). |
Gotcha. Even if there are no changes? Anyways, please cancel the official build once this is merged. |
e.g., look at all the "6.0-preview1" and "6.0-preview2" runs here: https://dev.azure.com/dnceng/public/_build?definitionId=658 |
Yes, the pipelines are running even if there are no changes (now).
You'll need to tell me how that is done. (does the official build automatically get kicked off for every merge?) |
@ViktorHofer @hoyosjs @safern This change (and the related 6.0 preview 1 change: #49168) didn't work. I change the YAML to use "always: false" for the schedule, meaning it should only trigger if there is a change. However, we're still getting test runs every day, and they all have a single change. Technically, the documentation says, "if there have been source code changes since the last successful scheduled run". Since there hasn't been a successful run, that's probably why we're getting runs. Given that we don't care about these runs, I propose to push new PRs to remove the schedules entirely for the preview releases, as well as for main (before it gets branched again). Comments? |
6.0 release branches are running AzDO stress pipelines on a schedule, even though (normally) nothing is changing. Change this to only run if something changes.
This is a port of #49020 to the release branch.