Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress the exception thrown when DiagnosticSourceEventSource access object properties #49567

Merged
merged 2 commits into from
Mar 15, 2021
Merged

Suppress the exception thrown when DiagnosticSourceEventSource access object properties #49567

merged 2 commits into from
Mar 15, 2021

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 13, 2021

No description provided.

@ghost
Copy link

ghost commented Mar 13, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Tracing
Milestone: -

@tarekgh tarekgh requested a review from noahfalk March 13, 2021 02:04
@ghost
Copy link

ghost commented Mar 13, 2021

Tagging subscribers to this area: @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: tarekgh
Assignees: -
Labels:

area-System.Diagnostics.Activity
Milestone: -

@tarekgh tarekgh added this to the 6.0.0 milestone Mar 13, 2021
@tarekgh tarekgh self-assigned this Mar 13, 2021
noahfalk
noahfalk approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo adding some diagnostic logging, LGTM

...es/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Show resolved Hide resolved
...es/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Outdated Show resolved Hide resolved
@runfoapp runfoapp bot mentioned this pull request Mar 15, 2021
Open
@tarekgh tarekgh merged commit 314d1e7 into dotnet:main Mar 15, 2021
@tarekgh tarekgh deleted the AvoidExceptionsInDiagnosticSourceEventSource branch March 15, 2021 18:05
@pakrym pakrym mentioned this pull request Mar 15, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@noahfalk noahfalk noahfalk approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Diagnostics.Activity
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekgh @stephentoub @noahfalk