Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass CORINFO_CALLINFO_ALLOWINSTPARAM to speculative eeGetCallInfo #51088

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Pass CORINFO_CALLINFO_ALLOWINSTPARAM to speculative eeGetCallInfo #51088

merged 1 commit into from
Apr 12, 2021

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 11, 2021

Pass CORINFO_CALLINFO_ALLOWINSTPARAM to speculative eeGetCallInfo to make it cheaper

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2021
@jkotas
Copy link
Member Author

jkotas commented Apr 11, 2021

Run into this during integration into runtimelab:NativeAOT branch.

@jkotas jkotas mentioned this pull request Apr 11, 2021
Closed
tannergooding
tannergooding approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm going to work on adding isJitIntrinsic (which reports CORINFO_FLG_JIT_INTRINSIC) so we can reduce the cost here even more.

@jkotas jkotas merged commit 1119725 into dotnet:main Apr 12, 2021
@jkotas jkotas deleted the callinfo branch April 12, 2021 15:26
@JulieLeeMSFT JulieLeeMSFT added this to the 6.0.0 milestone Apr 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@jkotas jkotas

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @tannergooding @JulieLeeMSFT