Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple simple cleanups in singlefile/bundle #52995

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

VSadov
Copy link
Member

@VSadov VSadov commented May 19, 2021

  • We should enable compression for all kinds of files, except for those we explicitly do not want to compress
    This effectively just flips what we do with "Unknown" kind.

  • Removed an outdated comment.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-HostModel Microsoft.NET.HostModel issues label May 19, 2021
@ghost
Copy link

ghost commented May 19, 2021

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details
  • We should enable compression for all kinds of files, except for those we explicitly do not want to compress
    This effectively just flips what we do with "Unknown" kind.

  • Removed an outdated comment.

Author: VSadov
Assignees: -
Labels:

area-HostModel

Milestone: -

@VSadov VSadov requested a review from vitek-karas May 19, 2021 21:45
@VSadov
Copy link
Member Author

VSadov commented May 20, 2021

Thanks!!

@VSadov VSadov merged commit d81ad04 into dotnet:main May 20, 2021
@VSadov
Copy link
Member Author

VSadov commented May 20, 2021

@agocke - with this change "Unknown" files will be able to compress as well.
For everything else compression was already enabled.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants