Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple simple cleanups in singlefile/bundle #52995

Merged
merged 2 commits into from
May 20, 2021
Merged

Couple simple cleanups in singlefile/bundle #52995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd4f7d
compress all kinds of files (except DepsJson and RuntimeConfigJson)
VSadov May 19, 2021
73e0794
outdated comment
VSadov May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/installer/managed/Microsoft.NET.HostModel/Bundle/Bundler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,12 @@ private bool ShouldCompress(FileType type)

switch (type)
{
case FileType.Symbols:
case FileType.NativeBinary:
case FileType.Assembly:
return true;
case FileType.DepsJson:
case FileType.RuntimeConfigJson:
return false;

default:
return false;
return true;
}
}

Expand Down
3 changes: 1 addition & 2 deletions src/native/corehost/corehost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,7 @@ int exe_start(const int argc, const pal::char_t* argv[])
}
else
{
// The host components will be statically linked with the app-host: https://github.com/dotnet/runtime/issues/32823
// Once this work is completed, an outdated hostfxr can only be found for framework-related apps.
// An outdated hostfxr can only be found for framework-related apps.
trace::error(_X("The required library %s does not support single-file apps."), fxr.fxr_path().c_str());
need_newer_framework_error();
rc = StatusCode::FrameworkMissingFailure;
Expand Down