[Release/5.0] - Fix versions for Libs native artifacts #53000
Conversation
Port of dotnet#52799 and dotnet#52917 During the repo consolidation, we missed passing OfficialBuildId argument to common script from all subsets, which resulted in default version emitted in the binaries produced by Libs subset in the official builds.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsDuring the repo consolidation, we missed passing OfficialBuildId Customer ImpactVersion of libraries native binaries cannot be figured out. TestingBuilt libraries and manually checked that the build Id is there. RiskLow, it only adds the missing embedded version hash / official version number to the binaries. RegressionYes, it was ok in 3.1, got broken during repo consolidation.
|
|
@am11 the singlefilehost was already ok, I guess it got broken in 6.0 branch by the versioning changes there. As for the other commit, I've already incorporated the quoting there. So this change results in everything having the right version and nothing being broken. |
|
@am11, ah, I can see that I've not added the check for empty version id that was the other commit you've mentioned. |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Port of #52799 and #52917
During the repo consolidation, we missed passing OfficialBuildId
argument to common script from all subsets, which resulted in default
version emitted in the binaries produced by Libs subset in the official
builds.
Customer Impact
Version of libraries native binaries cannot be figured out.
Testing
Built libraries and manually checked that the build Id is there.
Risk
Low, it only adds the missing embedded version hash / official version number to the binaries.
Regression
Yes, it was ok in 3.1, got broken during repo consolidation.