Make the lookup for getApplicationProtocol optional #53001
Conversation
The method getApplicationProtocol in javax.net.ssl.SSLEngine is only supported on API level 29 and above, so running on older devices would result in a crash. This change makes the initial method lookup optional and AndroidCryptoNative_SSLStreamGetApplicationProtocol in pal_sslstream.c will error if it is not supported. Fixes dotnet#52965
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThe method getApplicationProtocol in javax.net.ssl.SSLEngine is only supported on API level 29 and above, so running on older devices would result in a crash. This change makes the initial method lookup optional and AndroidCryptoNative_SSLStreamGetApplicationProtocol in pal_sslstream.c will error if it is not supported. Fixes #52965
|
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_sslstream.c
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_sslstream.c
Show resolved
Hide resolved
|
@akoeplinger Do you think we should backport this? |
|
Yes because otherwise Xamarin Android applications won't run on API<29 in preview5. |
|
/backport to release/6.0-preview5 |
|
Started backporting to release/6.0-preview5: https://github.com/dotnet/runtime/actions/runs/863314657 |
ghost
locked as resolved and limited conversation to collaborators
The method getApplicationProtocol in javax.net.ssl.SSLEngine is only supported on API level 29 and above, so running on older devices would result in a crash.
This change makes the initial method lookup optional and AndroidCryptoNative_SSLStreamGetApplicationProtocol in pal_sslstream.c will error if it is not supported.
Fixes #52965