[Mono] MSBuild Task housekeeping #54485
Conversation
…ppToolCurrent one as NetCoreAppToolCurrent will likely bump more aggressively between new sdks
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
MaximLipnin
requested review from
mdh1418,
directhex,
marek-safar,
radical,
steveisok and
akoeplinger
src/tasks/Directory.Build.props
Outdated
| @@ -3,5 +3,6 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworkForNETFramework>net472</TargetFrameworkForNETFramework> | |||
| <TargetFrameworkForNetCore>net6.0</TargetFrameworkForNetCore> | |||
There was a problem hiding this comment.
In general, what criteria will push us to update this value?
There was a problem hiding this comment.
Nit: TargetFrameworkForNETCore?
There was a problem hiding this comment.
Any new features we may need. We may not need to bump all that often.
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFramework>$(NetCoreAppToolCurrent)</TargetFramework> | |||
| <TargetFramework>$(TargetFrameworkForNetCore)</TargetFramework> | |||
There was a problem hiding this comment.
Is this intended just for tasks? If so, then we should name it accordingly. It's not clear from the name, what it is for, or when to use it.
There was a problem hiding this comment.
Perhaps, but it looks quite consistent in other places, e.g. in MonoAOTCompiler task <TargetFrameworks>$(TargetFrameworkForNetCore);$(TargetFrameworkForNETFramework)</TargetFrameworks>
There was a problem hiding this comment.
It seems like the property is intended just to be used in src/tasks. Not sure if TargetFrameworkForNETFramework is also intended to be just used in src/tasks as well, but if it is perhaps we can rename them both to be something like TargetFrameworkForNETCoreTasks and TargetFrameworkForNETFrameworkTasks?
There was a problem hiding this comment.
@radical if it is intended for just the tasks, do you think the above would be proper, or did you have something else in mind?
There was a problem hiding this comment.
.. but if it is perhaps we can rename them both to be something like TargetFrameworkForNETCoreTasks and TargetFrameworkForNETFrameworkTasks
Sounds good.
There was a problem hiding this comment.
A quick search showed that the TargetFrameworkForNETFramework property is used within src\task only so I've made the following change:
TargetFrameworkForNETFramework -> TargetFrameworkForNETFrameworkTasks
TargetFrameworkForNetCore -> TargetFrameworkForNETCoreTasks
|
The failures are not related |
…bugger2 * origin/main: (78 commits) Fix unreached during dump. (dotnet#54861) Fix lowering usage of an unset LSRA field. (dotnet#54731) Fix setting breakpoints on AVX 256 instructions and other 32 byte immediate instructions (dotnet#54786) Add perf_slow yaml (dotnet#54853) Faster type load for scenarios made more common by generic math (dotnet#54588) Make sure we consider buffer length when marshalling back Unicode ByValTStr fields (dotnet#54695) Add YieldProcessor implementation for arm (dotnet#54829) Remove ActiveIssue for dotnet#50968 (dotnet#54831) Enable System.Text.Json tests for Wasm AOT (dotnet#54833) Remove ActiveIssue for dotnet#51723 (dotnet#54830) Fix load exception on generic covariant return type (dotnet#54790) Obsolete X509Certificate2.PrivateKey and PublicKey.Key. (dotnet#54562) First round of converting System.Drawing.Common to COMWrappers (dotnet#54636) Fix alloc-dealloc mismatches (dotnet#54701) Add one-shot ECB methods [Mono] MSBuild Task housekeeping (dotnet#54485) Move iOS/tvOS simulator AOT imports in the Mono workload (dotnet#54821) Remove unnecessary char[] allocation from Uri.GetRelativeSerializationString (dotnet#54799) Reduce overhead of Enumerable.Chunk (dotnet#54782) Fix EnumMemberRefs always returning NULL (dotnet#54805) ...
ghost
locked as resolved and limited conversation to collaborators
#53873
TargetFrameworkForNETCoreTasksproperty similar toNetCoreAppToolCurrentone asNetCoreAppToolCurrentwill likely bump more aggressively between new sdks.TargetFrameworkForNETFrameworktoTargetFrameworkForNETFrameworkTasks