Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from 11 repositories #54741

Merged
merged 18 commits into from
Jun 29, 2021
Merged

[main] Update dependencies from 11 repositories #54741

merged 18 commits into from
Jun 29, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 25, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20210628.3
  • Date Produced: 6/28/2021 2:14 PM
  • Commit: acab64cb4dfe9fe1a7c1b77b45eda2d91327e9da
  • Branch: refs/heads/main

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20210624.3
  • Date Produced: 6/24/2021 6:29 PM
  • Commit: a68ec1edf328e737b31a09cb49e1929c28e91d0c
  • Branch: refs/heads/main

From https://github.com/dotnet/icu

  • Subscription: 4247a230-8931-4538-5b64-08d8d8feb47e
  • Build: 20210621.1
  • Date Produced: 6/21/2021 1:09 PM
  • Commit: 9045735745b259d81d6754122992ad1183fa4b83
  • Branch: refs/heads/maint/maint-67

From https://github.com/dotnet/llvm-project

  • Subscription: b8108dfc-f542-401a-9375-08d8d8ff2d75
  • Build: 20210621.1
  • Date Produced: 6/21/2021 3:16 PM
  • Commit: 26f8bf7b3d57b59dd3b3bd7269b3303e87b298df
  • Branch: refs/heads/release/11.x

From https://github.com/dotnet/runtime-assets

  • Subscription: 0c5a34f5-504e-413b-9376-08d8d8ff2d75
  • Build: 20210623.1
  • Date Produced: 6/23/2021 11:01 AM
  • Commit: 6e96a8810e85650ec9d5618d5ede5ce14c964d2a
  • Branch: refs/heads/main

From https://github.com/mono/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20210627.1
  • Date Produced: 6/28/2021 7:14 AM
  • Commit: 1c0138c71850bdab14d740e9c4c8808ed034dc51
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: a712faa5-42ec-4225-f239-08d913ef4ff4
  • Build: 20210621.1
  • Date Produced: 6/21/2021 12:26 PM
  • Commit: 0451564eb2f0ec1e1b614a21ee3836d24baf2572
  • Branch: refs/heads/main

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20210624.1
  • Date Produced: 6/24/2021 5:40 PM
  • Commit: c801eb6e3532e2b6f36d9559c9174d1c7cf14c09
  • Branch: refs/heads/release/6.0.1xx

From https://github.com/dotnet/runtime

  • Subscription: 772acd8f-b0cb-4d38-9377-08d8d8ff2d75
  • Build: 20210628.2
  • Date Produced: 6/28/2021 10:22 AM
  • Commit: 91599ff
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20210628.2
  • Date Produced: 6/28/2021 8:36 AM
  • Commit: 0bc5e50
  • Branch: refs/heads/main

From https://github.com/dotnet/emsdk

  • Subscription: c22d5069-447c-4252-29fd-08d90a7bb4bc
  • Build: 20210628.1
  • Date Produced: 6/28/2021 12:39 PM
  • Commit: d2873833db748a95140f507d639cbdfdf78d4fd7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
c6c9510 
…otnet-optimization build 20210624.4

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21320.4 -> To Version 1.0.0-prerelease.21324.4
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
2cdfe73 
…624.3

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21321.1 -> To Version 6.0.0-beta.21324.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/icu build 20210621.1
990b188 
Microsoft.NETCore.Runtime.ICU.Transport
 From Version 6.0.0-preview.7.21315.3 -> To Version 6.0.0-preview.7.21321.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
3f64f14 
… 20210621.1

runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.21314.1 -> To Version 11.1.0-alpha.1.21321.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime-assets bui…
ecfd50e 
…ld 20210623.1

System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
 From Version 6.0.0-beta.21314.1 -> To Version 6.0.0-beta.21323.1
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210622.1
e9f9ebc 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21317.4 -> To Version 6.0.100-preview.6.21322.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
3252802 
…ild 20210621.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.1-alpha.0.21314.1 -> To Version 1.0.1-alpha.0.21321.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/roslyn-analyzers b…
9297b2e 
…uild 20210624.1

Microsoft.CodeAnalysis.NetAnalyzers
 From Version 6.0.0-rc1.21320.2 -> To Version 6.0.0-rc1.21324.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dnceng/internal/dotnet-optimization [main] Update dependencies from 8 repositories Jun 25, 2021
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
52069b6 
…otnet-optimization build 20210626.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21320.4 -> To Version 1.0.0-prerelease.21326.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
fc93fb0 
…0628.2

Microsoft.NETCore.DotNetHost , Microsoft.NETCore.DotNetHostPolicy , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , Microsoft.NET.Sdk.IL , System.Runtime.CompilerServices.Unsafe , System.Text.Json
 From Version 6.0.0-preview.7.21321.2 -> To Version 6.0.0-preview.7.21328.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from 8 repositories [main] Update dependencies from 9 repositories Jun 28, 2021
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
5c4f00b 
…otnet-optimization build 20210627.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21320.4 -> To Version 1.0.0-prerelease.21327.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
bd087fa 
…10628.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.21324.2 -> To Version 1.0.0-prerelease.21328.2
@dotnet-maestro
Update dependencies from https://github.com/mono/linker build 20210627.1
4779c57 
Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21317.4 -> To Version 6.0.100-preview.6.21327.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from 9 repositories [main] Update dependencies from 10 repositories Jun 28, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/emsdk build 202106…
58a7ffc 
…28.1

Microsoft.NET.Runtime.Emscripten.2.0.23.Node.win-x64
 From Version 6.0.0-preview.7.21323.1 -> To Version 6.0.0-preview.7.21328.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from 10 repositories [main] Update dependencies from 11 repositories Jun 28, 2021
@eerhardt
Copy link
Member

I'm looking into the build break due to the linker update:

C:\git\runtime\src\libraries\System.Private.CoreLib\src\System\Reflection\Emit\AssemblyBuilder.cs(11,33): error IL3003: Base member 'System.Reflection.Assembly.CodeBase' with 'RequiresAssemblyFilesAttribute' has a derived member 'System.Reflection.Emit.AssemblyBuilder.CodeBase' without 'RequiresAssemblyFilesAttribute'. Attributes must match across all interface implementations or overrides. [C:\git\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]
C:\git\runtime\src\coreclr\System.Private.CoreLib\src\System\Reflection\RuntimeAssembly.cs(86,33): error IL3003: Base member 'System.Reflection.Assembly.CodeBase' with 'RequiresAssemblyFilesAttribute' has a derived member 'System.Reflection.RuntimeAssembly.CodeBase' without 'RequiresAssemblyFilesAttribute'. Attributes must match across all interface implementations or overrides. [C:\git\runtime\src\coreclr\System.Private.CoreLib\System.Private.CoreLib.csproj]

@eerhardt
Copy link
Member

cc @tlakollo @vitek-karas - PTAL at the changes I made for the new IL3002 and IL3003 warnings.

@eerhardt eerhardt mentioned this pull request Jun 28, 2021
Closed
@tlakollo
Copy link
Contributor

cc @tlakollo @vitek-karas - PTAL at the changes I made for the new IL3002 and IL3003 warnings.

Thanks for handling this Erich! Sorry for not picking this up earlier since I knew it was going to fail. This is related to changes in dotnet/linker#2046 and fixes #54154 by introducing IL3003. Although not necessary so far, I would include IL3003 in the list of suppressions for tests in runtime/eng/CodeAnalysis.test.ruleset, there is a block that suppresses single file warnings in test projects

@eerhardt eerhardt mentioned this pull request Jun 28, 2021
Closed
dotnet-maestro bot and others added 2 commits June 29, 2021 12:15
@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
57b5239 
…otnet-optimization build 20210628.3

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21320.4 -> To Version 1.0.0-prerelease.21328.3
@marek-safar
Merge branch 'main' into darc-main-997daf91-1bd1-4e82-9eac-1347a9231dc5
cd86492
@dotnet-maestro dotnet-maestro bot merged commit 8103a7e into main Jun 29, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-997daf91-1bd1-4e82-9eac-1347a9231dc5 branch June 29, 2021 16:02
@eerhardt
Copy link
Member

Did this even run CI before it merged? I believe this happened last week as well.

cc @ViktorHofer @mmitche @MattGal

ViktorHofer added a commit that referenced this pull request Jun 29, 2021
@ViktorHofer
Revert "[main] Update dependencies from 11 repositories (#54741)"
b35185e 
This reverts commit 8103a7e.
@ViktorHofer ViktorHofer mentioned this pull request Jun 29, 2021
Merged
@ViktorHofer
Copy link
Member

Opened #54909 to revert the change. We can't let this get into main without any validation. @MattGal @mmitche I think someone opened a core-eng issue for these unprotected merges?

ViktorHofer added a commit that referenced this pull request Jun 29, 2021
@ViktorHofer
Revert "[main] Update dependencies from 11 repositories (#54741)" (#5…
6f7f30e 
…4909)

This reverts commit 8103a7e.
@MattGal
Copy link
Member

MattGal commented Jun 29, 2021

Yes, the issue is fixed as well and the fix should roll out tomorrow as part of https://github.com/dotnet/arcade-services/pull/1664/files

@ericstj ericstj mentioned this pull request Jun 30, 2021
Merged
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tlakollo tlakollo tlakollo approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@eerhardt @tlakollo @ViktorHofer @MattGal @danmoseley @marek-safar