Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open types can exist as entries in interface map #55372

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Open types can exist as entries in interface map #55372

merged 2 commits into from
Jul 13, 2021

Commits on Jul 8, 2021

  1. Open types can exist as entries in interface map 

    - While invalid via the ECMA spec, the runtime currently represents a type explicitly instantiated over its own generic type parameters via the open type MethodTable
- This is not strictly correct, as per the spec, these should be represented via an instantiated type, but changing that detail at this time is considered highly risky
- This conflicts with the perf optimization around partialy interface loading which uses the open type of an interface to represent a type instantiated in the curiously recurring fashion.
- The fix is to detect types instantiated over generic variables, and make them ineligible for the optimization, and to detect those cases where the optimization is ineligible, and revert back to the non-optimized behavior

Fixes dotnet#55323
    @davidwrighton
    davidwrighton committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a32209e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Get the polarity right on ContainsGenericVariables checks

    @davidwrighton
    davidwrighton committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    de48a70 View commit details
    Browse the repository at this point in the history