Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Quic tracing easier to correlate with MsQuic #55483

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jul 11, 2021

This PR adds Handle to the trace and create little helpers for it.
With that we can do:

[MsQuicConnection#20974680/7fe2a4004460] received event IDEAL_PROCESSOR_CHANGED
[MsQuicConnection#58366981/7fe2940ad370] received event PEER_CERTIFICATE_RECEIVED

$ grep 7fe2a4004460 quic.log

[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] Created, IsServer=1, CorrelationId=1
[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] OUT: BytesSent=0 InFlight=0 InFlightMax=0 CWnd=0 SSThresh=4294967295 ConnFC=0 ISB=131072 PostedBytes=0 SRtt=0
[0][27cf3a.27cf49][04:01:00.363545][conn][0x7fe2a4004460] OUT: StreamFC=0 StreamSendWindow=0
[0][27cf3a.27cf49][04:01:00.363545][conn][0x7fe2a4004460] CUBIC: SlowStartThreshold=4294967295 K=0 WindowMax=0 WindowLastMax=0
[0][27cf3a.27cf49][04:01:00.363547][conn][0x7fe2a4004460] Path[0] Initialized
[0][27cf3a.27cf49][04:01:00.363547][conn][0x7fe2a4004460] QUIC Version: 16777216

not only we have hash that is pretty useless (aside from providing somewhat unique identifier) but we can also directly to native MsQuic tracing.

Note that I updated only critical events e.g. creation/destruction and native callback handler.
I'd be happy to update all tracing instances if we want to.

@wfurt wfurt requested a review from a team July 11, 2021 23:35
@wfurt wfurt self-assigned this Jul 11, 2021
@ghost
Copy link

ghost commented Jul 11, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR adds Handle to the trace and create little helpers for it.
With that we can do:

[MsQuicConnection#20974680/7fe2a4004460] received event IDEAL_PROCESSOR_CHANGED
[MsQuicConnection#58366981/7fe2940ad370] received event PEER_CERTIFICATE_RECEIVED

$ grep 7fe2a4004460 quic.log

[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] Created, IsServer=1, CorrelationId=1
[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] OUT: BytesSent=0 InFlight=0 InFlightMax=0 CWnd=0 SSThresh=4294967295 ConnFC=0 ISB=131072 PostedBytes=0 SRtt=0
[0][27cf3a.27cf49][04:01:00.363545][conn][0x7fe2a4004460] OUT: StreamFC=0 StreamSendWindow=0
[0][27cf3a.27cf49][04:01:00.363545][conn][0x7fe2a4004460] CUBIC: SlowStartThreshold=4294967295 K=0 WindowMax=0 WindowLastMax=0
[0][27cf3a.27cf49][04:01:00.363547][conn][0x7fe2a4004460] Path[0] Initialized
[0][27cf3a.27cf49][04:01:00.363547][conn][0x7fe2a4004460] QUIC Version: 16777216

not only we have hash that is pretty useless (aside from providing somewhat unique identifier) but we can also directly to native MsQuic tracing.

Note that I updated only critical events e.g. creation/destruction and native callback handler.
I'd be happy to update all tracing instances if we want to.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

@wfurt wfurt merged commit d766727 into dotnet:main Jul 12, 2021
@wfurt wfurt deleted the tracingQuic2 branch July 12, 2021 03:32
@ManickaP
Copy link
Member

cc: @CarnaViire I think you planned to add something similar. If you had the logging more widespread, maybe we could adapt it and get in more places where we log.

@CarnaViire
Copy link
Member

Yes. I'll put up a PR after I resolve conflicts with this

@CarnaViire CarnaViire mentioned this pull request Jul 12, 2021
CarnaViire added a commit that referenced this pull request Jul 12, 2021
Together with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one.
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants