Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC logging update #55500

Merged
merged 4 commits into from
Jul 12, 2021
Merged

QUIC logging update #55500

merged 4 commits into from
Jul 12, 2021

Conversation

CarnaViire
Copy link
Member

Together with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.:

[list][0x1DF7EA41280] Listener started
[conn][0x1DF7EFC2A40] Outbound connection created
[strm][0x1DF7EFC71D0] Stream disposing True

@ghost
Copy link

ghost commented Jul 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Together with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.:

[list][0x1DF7EA41280] Listener started
[conn][0x1DF7EFC2A40] Outbound connection created
[strm][0x1DF7EFC71D0] Stream disposing True
Author: CarnaViire
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Jul 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Together with #55483 this updates all logging to use msquic handles instead of hash code - for listeners, connections and streams. The format of handle is the same as msquic one, e.g.:

[list][0x1DF7EA41280] Listener started
[conn][0x1DF7EFC2A40] Outbound connection created
[strm][0x1DF7EFC71D0] Stream disposing True
Author: CarnaViire
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@CarnaViire CarnaViire merged commit 102fc35 into dotnet:main Jul 12, 2021
@wfurt
Copy link
Member

wfurt commented Jul 12, 2021

Did you get the trace sample on Windows?
On Linux I get

[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] Created, IsServer=1, CorrelationId=1
[0][27cf3a.27cf49][04:01:00.363544][conn][0x7fe2a4004460] OUT: BytesSent=0 InFlight=0 InFlightMax=0 CWnd=0 

Seems like different casing on pointers. I'm wondering if this is something intentional or something that can be fixed @nibanks.

@nibanks
Copy link

nibanks commented Jul 12, 2021

We use CLOG to convert the LTTng traces on Linux and generally netsh to convert the ETW traces on Windows. Right now, there's no guarantee that casing will be the same across everything.

@wfurt
Copy link
Member

wfurt commented Jul 12, 2021

Improvement for CLOG? While you can use case insensitive text search it would be nice if this is as simple as possible.
Is the pointer field structured data in the trace or is it something msquic creates?

@CarnaViire
Copy link
Member Author

Did you get the trace sample on Windows?

Yes; on Windows it's uppercase 🙁

[1]6710.4AE4::2021/07/09-22:49:11.406016000 [Microsoft-Quic][conn][0x1AF41D72A40] Execute: 4(FLUSH_SEND)

@CarnaViire CarnaViire deleted the quic-logging-update branch July 12, 2021 16:40
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants