[release/6.0-preview7] Update analyzer rulesets #56039
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
You're disabling many more analyzers than just the preview one. Is that right? If this is necessary for the build to not be broken, we don't need Steve's approval. You can merge it when it's signed off. |
pgovind
force-pushed
the
backport/pr-55925-to-release/6.0-preview7
branch
from
b464ab7
to
753399c
Compare
|
@stephentoub : I pared your change down to just disabling CA2252. Sign off when you get a chance please? |
|
Hello @pgovind! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsBackport of #55925 to release/6.0-preview7 /cc @pgovind @stephentoub Customer ImpactThe latest analyzer bits will cause dotnet/runtime's build to fail with warnings. With dotnet/sdk#19084, the latest analyzer bits will make it to the sdk's P7 branch. I'm not sure if an update to the sdk's branch will trigger a dotnet/runtime build, but I want to be safe here anyway and turn off the DetectPreviewFeatures analyzer for dotnet/runtime. We'll turn on preview features and iterate on the analyzer over the RC1 timeframe to fix the warnings for RC1 TestingNo product change here, not sure there's anything to test RiskMinimal. We're already doing this in upstream/main.
|
|
@danmoseley : When you get a chance, can you merge this PR please? (It looks like I'm not authorized to merge it?) The test failures are websocket HTTP stuff unrelated to the change. |
|
I'm not either, Please ask on the infra channel and someone will do it promptly. |
|
I can take care of it if needed, just let me know when the build is done. |
|
Apologies, while this PR appears ready to be merged, it looks like |
1 similar comment
|
Apologies, while this PR appears ready to be merged, it looks like |
|
Thanks @safern ! |
ghost
locked as resolved and limited conversation to collaborators
Backport of #55925 to release/6.0-preview7
/cc @pgovind @stephentoub
Customer Impact
The latest analyzer bits will cause dotnet/runtime's build to fail with warnings. With dotnet/sdk#19084, the latest analyzer bits will make it to the sdk's P7 branch. I'm not sure if an update to the sdk's branch will trigger a dotnet/runtime build, but I want to be safe here anyway and turn off the DetectPreviewFeatures analyzer for dotnet/runtime. We'll turn on preview features and iterate on the analyzer over the RC1 timeframe to fix the warnings for RC1
Testing
No product change here, not sure there's anything to test
Risk
Minimal. We're already doing this in upstream/main.