Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success timing out #55774

Open
jaredpar opened this issue Jul 15, 2021 · 4 comments
Labels
area-System.Net.Http bug disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
Milestone

Comments

@jaredpar
Copy link
Member

Failure query

https://runfo.azurewebsites.net/search/tests/?q=started%3A~7%20definition%3Aruntime%20name%3A%22system.net.http.functional.tests.socketshttphandlertest_http3_msquic.clientsettingsreceived_success%22

Test failures typically have the following call stack

    System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success(headerSizeLimit: 10) [FAIL]
      System.TimeoutException : The operation has timed out.
      Stack Trace:
        /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(49,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks, Int32 millisecondsTimeout)
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs(78,0): at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ClientSettingsReceived_Success(Int32 headerSizeLimit)
        --- End of stack trace from previous location ---

Note: thus far this has only failed in Pull Requests so it's not definitively a bug. However the PRs aren't networking related to my understanding hence seems more likely it is a bug here. It's also hit 14 times now.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Http untriaged New issue has not been triaged by the area owner labels Jul 15, 2021
@ghost
Copy link

ghost commented Jul 15, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Failure query

https://runfo.azurewebsites.net/search/tests/?q=started%3A~7%20definition%3Aruntime%20name%3A%22system.net.http.functional.tests.socketshttphandlertest_http3_msquic.clientsettingsreceived_success%22

Test failures typically have the following call stack

    System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success(headerSizeLimit: 10) [FAIL]
      System.TimeoutException : The operation has timed out.
      Stack Trace:
        /_/src/libraries/Common/tests/System/Threading/Tasks/TaskTimeoutExtensions.cs(49,0): at System.Threading.Tasks.TaskTimeoutExtensions.WhenAllOrAnyFailed(Task[] tasks, Int32 millisecondsTimeout)
        /_/src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs(78,0): at System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http3.ClientSettingsReceived_Success(Int32 headerSizeLimit)
        --- End of stack trace from previous location ---

Note: thus far this has only failed in Pull Requests so it's not definitively a bug. However the PRs aren't networking related to my understanding hence seems more likely it is a bug here. It's also hit 14 times now.

Author: jaredpar
Assignees: -
Labels:

area-System.Net.Http, untriaged

Milestone: -

@ManickaP ManickaP added this to the 6.0.0 milestone Jul 16, 2021
@ManickaP ManickaP added this to To Do (Low Priority) in HTTP/3 via automation Jul 16, 2021
@ManickaP ManickaP added test-bug Problem in test source code (most likely) and removed untriaged New issue has not been triaged by the area owner labels Jul 16, 2021
@ManickaP ManickaP moved this from To Do (Low Priority) to To Do (High Priority) in HTTP/3 Jul 16, 2021
@ManickaP
Copy link
Member

Triage: 27 occurrences so far, we might disable it. For 6.0 we need to at least rule out whether it's product bug

"Method": ClientSettingsReceived_Success,
"count_": 27,
"min_Queued": 2021-07-15T02:49:58.522Z,

@ManickaP ManickaP added bug and removed test-bug Problem in test source code (most likely) labels Jul 16, 2021
@karelz karelz changed the title SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success timing out [HTTP/3] SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Success timing out Jul 16, 2021
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Jul 16, 2021
@karelz
Copy link
Member

karelz commented Jul 16, 2021

Failures 5/17-7/16 (incl. PRs):

Date Failures
7/15 20 failures -- 19x Fedora.32.Amd64.Open, 1x Debian.10.Amd64.Open (Mock) ... 2 official builds ... 2x Mock
7/16 12 failures (so far) - 11x Fedora.32.Amd64.Open, 1x Ubuntu.1804.ArmArch.Open ... 3 official builds ... 1x Mock

We should disable it at least on Fedora ASAP to avoid creating noise for everybody in PRs.
UPDATE: We run non-Mock tests only on Fedora now ... that's why we see mainly that. Real msquic implementation has likely sufficiently different timing that it started failing frequently. Though Mock test version started failing also only recently, so perhaps some product change introduced that?

await new[] { clientTask, serverTask }.WhenAllOrAnyFailed(20_000);

karelz added a commit that referenced this issue Jul 16, 2021
…ccess test

Started failing too frequently - see #55774
@ManickaP ManickaP added the disabled-test The test is disabled in source code against the issue label Jul 16, 2021
stephentoub pushed a commit that referenced this issue Jul 16, 2021
@karelz
Copy link
Member

karelz commented Jul 16, 2021

Test disabled in PR #55811 on 7/16

Failures from Preview 7 branch (which branched without the test disabled) 7/16-7/27 (incl. PRs):

Day Run
7/21 PR #56039
7/23 PR #56013
7/23 PR #56240
7/23 PR #56250
7/23 PR #56235
7/23 PR #56255
7/24 PR #56255
7/26 PR #56255
7/27 PR #56330

danmoseley pushed a commit to danmoseley/runtime that referenced this issue Jul 26, 2021
stephentoub pushed a commit that referenced this issue Jul 27, 2021
…ccess test (#55811) (#56338)

Started failing too frequently - see #55774

Co-authored-by: Karel Zikmund <karelz@microsoft.com>
@ManickaP ManickaP moved this from To Do (High Priority) to To Do (Disabled Tests) in HTTP/3 Aug 4, 2021
@ManickaP ManickaP modified the milestones: 6.0.0, Future Aug 10, 2021
@CarnaViire CarnaViire self-assigned this Sep 3, 2021
@CarnaViire CarnaViire moved this from To Do (Disabled Tests) to In Progress in HTTP/3 Sep 3, 2021
@karelz karelz moved this from In Progress to To Do (Disabled Tests) in HTTP/3 Sep 21, 2021
@rzikm rzikm self-assigned this Apr 1, 2022
@rzikm rzikm removed their assignment Apr 8, 2022
@karelz karelz moved this from To Do (Disabled Tests) to Future in HTTP/3 Jun 28, 2022
@karelz karelz moved this from Future to To Do (Disabled Tests) in HTTP/3 Jun 28, 2022
@ManickaP ManickaP moved this from To Do (Disabled Tests) to Future in HTTP/3 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Net.Http bug disabled-test The test is disabled in source code against the issue test-run-core Test failures in .NET Core test runs
Projects
No open projects
HTTP/3
  
Future
Development

No branches or pull requests

5 participants