Set CMAKE_OSX_DEPLOYMENT_TARGET for all Mono AOT compilers on macOS #57507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just if we're targetting iOS/tvOS/macOS since the AOT compiler for WASM or Android can run on macOS too. Fixes dotnet#57431
lambdageek
reviewed
Aug 16, 2021
lambdageek
approved these changes
Aug 16, 2021
vargaz
approved these changes
Aug 16, 2021
vargaz
approved these changes
Aug 16, 2021
lewing
approved these changes
Aug 16, 2021
|
runtime (Mono crossaot Product Build Linux x64 release) |
|
Failures are unrelated. |
|
browser failures are #57501 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just if we're targetting iOS/tvOS/macOS since the AOT compiler for WASM or Android can run on macOS too.
Fixes #57431