Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enregister Return SP check variable #59759

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

kunalspathak
Copy link
Member

Antigen found an issue that when COMPlus_JitStackChecks=1 was used, we hit the following assert. The ReturnSpCheck should be marked as DoNotEnregister.

Assert failure(PID 51312 [0x0000c870], Thread: 49364 [0xc0d4]): Assertion failed 'lvaStackPointerVar != 0xCCCCCCCC && compiler->lvaTable[lvaStackPointerVar].lvDoNotEnregister && compiler->lvaTable[lvaStackPointerVar].lvOnFrame' in 'ILStubClass:IL_STUB_ReversePInvoke(long,int,ubyte,long,long,long,long)' during 'Generate code' (IL size 98)

    File: D:\git\runtime\src\coreclr\jit\codegencommon.cpp Line: 11699
    Image: D:\git\runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\corerun.exe

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 29, 2021
@kunalspathak
Copy link
Member Author

@dotnet/jit-contrib

@ghost
Copy link

ghost commented Sep 29, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Antigen found an issue that when COMPlus_JitStackChecks=1 was used, we hit the following assert. The ReturnSpCheck should be marked as DoNotEnregister.

Assert failure(PID 51312 [0x0000c870], Thread: 49364 [0xc0d4]): Assertion failed 'lvaStackPointerVar != 0xCCCCCCCC && compiler->lvaTable[lvaStackPointerVar].lvDoNotEnregister && compiler->lvaTable[lvaStackPointerVar].lvOnFrame' in 'ILStubClass:IL_STUB_ReversePInvoke(long,int,ubyte,long,long,long,long)' during 'Generate code' (IL size 98)

    File: D:\git\runtime\src\coreclr\jit\codegencommon.cpp Line: 11699
    Image: D:\git\runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\corerun.exe
Author: kunalspathak
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

Failures seems to be unrelated.

@kunalspathak kunalspathak merged commit cf5c6a4 into dotnet:main Sep 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants