Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortedList<TKey, TValue> added GetKeyAtIndex, GetValueAtIndex, and SetValueAtIndex #60511

Closed
wants to merge 1 commit into from

Conversation

rhaokiel
Copy link
Contributor

@rhaokiel rhaokiel commented Oct 17, 2021

Implemented set value at index method.
Exposed get at index methods.
per approved API Proposal #58962

Implemented set value by index method.
Exposed get by index methods.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 17, 2021
@ghost
Copy link

ghost commented Oct 17, 2021

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Implemented set value at index method.
Exposed get at index methods.
per API Proposal #58962

Author: rhaokiel
Assignees: -
Labels:

area-System.Collections

Milestone: -

@dnfadmin
Copy link

dnfadmin commented Oct 17, 2021

CLA assistant check
All CLA requirements met.

@danmoseley
Copy link
Member

Thanks @rhaokiel . Can you please add tests? Also we need an update to the /ref/ file - it's next to the /src/. There is a special way to update it - please see docs folder for info on updating ref

@danmoseley
Copy link
Member

It's at docs/coding-guidelines/updating-ref-source.md

@rhaokiel rhaokiel closed this Oct 17, 2021
@rhaokiel rhaokiel deleted the patch-1 branch October 17, 2021 14:39
@eiriktsarpalis
Copy link
Member

@rhaokiel curious why you closed this?

@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants