Switch over miscellaneous DllImports to GeneratedDllImport. #62353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These P/Invokes slipped through the cracks for their respective libraries because they're either only used on platforms where getting the analyzer to run in VS is more difficult (CoreLib for mobile platforms) or they were missed in the first pass.
jkoritzinsky
requested review from
AaronRobinsonMSFT,
elinor-fung and
stephentoub
stephentoub
reviewed
Dec 3, 2021
src/libraries/Common/src/Interop/Windows/Advapi32/Interop.ChangeServiceConfig2.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Dec 3, 2021
AaronRobinsonMSFT
approved these changes
Dec 3, 2021
src/libraries/Common/src/Interop/Windows/User32/Interop.GetDC.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/User32/Interop.ReleaseDC.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/User32/Interop.SystemParametersInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/src/Interop/Windows/User32/Interop.WindowFromDC.cs
Outdated
Show resolved
Hide resolved
....Diagnostics.Tracing.EventSource.Redist/src/Microsoft/Diagnostics/Tracing/StubEnvironment.cs
Outdated
Show resolved
Hide resolved
....Diagnostics.Tracing.EventSource.Redist/src/Microsoft/Diagnostics/Tracing/StubEnvironment.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
…eference the live ref pack.
…er makes doing it during property evaluation difficult
jkoritzinsky
force-pushed
the
misc-gendllimport
branch
from
a99926d
to
c0022e1
Compare
jkoritzinsky
commented
Dec 8, 2021
src/libraries/Common/src/Interop/Unix/System.Native/Interop.GetNodeName.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Dec 8, 2021
|
|
||
| [DllImport(Libraries.Advapi32, CharSet = CharSet.Unicode, SetLastError = true)] | ||
| #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time | ||
| // TODO: [DllImportGenerator] Switch to use GeneratedDllImport once we support non-blittable types. |
There was a problem hiding this comment.
Would be better to reference tracking issue
There was a problem hiding this comment.
This is the comment pattern we've used even migrating over the rest of the DllImports, so I'd prefer to match that.
|
Curious why don't we have code analyzers/fixers for this? |
See the opening PR comment: It's not blanketly enabled as a warning for the whole repo yet as the team has been working through the changeover library by library. |
|
Great news. I didn't know there is an analyzer available already. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These P/Invokes slipped through the cracks for their respective libraries because they're either only used on platforms where getting the analyzer to run in VS is more difficult (CoreLib for mobile platforms) or they were missed in the first pass.