Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over miscellaneous DllImports to GeneratedDllImport. #62353

Merged
merged 13 commits into from Dec 9, 2021
Merged

Switch over miscellaneous DllImports to GeneratedDllImport. #62353

merged 13 commits into from Dec 9, 2021

Commits on Dec 3, 2021

  1. Switch over miscellaneous DllImports to GeneratedDllImport. 

    These P/Invokes slipped through the cracks for their respective libraries because they're either only used on platforms where getting the analyzer to run in VS is more difficult (CoreLib for mobile platforms) or they were missed in the first pass.
    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    f2006ec View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <arobins@microsoft.com>
    @jkoritzinsky @AaronRobinsonMSFT
    jkoritzinsky and AaronRobinsonMSFT committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    114246b View commit details
    Browse the repository at this point in the history

  3. Fix build breaks and enable DllImportGenerator in all projects that r… 

    …eference the live ref pack.
    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    9211cba View commit details
    Browse the repository at this point in the history

  4. Fix live ref pack enable condition

    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6eae8bf View commit details
    Browse the repository at this point in the history

  5. Make sure that we only try to enable the generator in source projects.

    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    e094856 View commit details
    Browse the repository at this point in the history

  6. Use the "item" to enable the generator for this case since import ord… 

    …er makes doing it during property evaluation difficult
    @jkoritzinsky
    jkoritzinsky committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    c0022e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Fix downlevel .NETCoreApp support

    @jkoritzinsky
    jkoritzinsky committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    8c553b9 View commit details
    Browse the repository at this point in the history

  2. More build fixes

    @jkoritzinsky
    jkoritzinsky committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    5f8d4e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Merge branch 'main' into misc-gendllimport

    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    aa2acef View commit details
    Browse the repository at this point in the history

  2. Fix another extern/partial typo

    @jkoritzinsky
    jkoritzinsky committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    d2c6cd9 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Update src/libraries/Common/src/Interop/Unix/System.Native/Interop.Ge… 

    …tNodeName.cs
    @jkoritzinsky
    jkoritzinsky committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    4e61dd8 View commit details
    Browse the repository at this point in the history

  2. Fix bad definition of GetNodeName (C# char != native char, ref instea… 

    …d of out)
    @jkoritzinsky
    jkoritzinsky committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    d949d7b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'misc-gendllimport' of github.com:jkoritzinsky/runtime i… 

    …nto misc-gendllimport
    @jkoritzinsky
    jkoritzinsky committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    311568e View commit details
    Browse the repository at this point in the history