Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Directory.Move and DirectoryInfo.MoveTo #63675

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Improve Directory.Move and DirectoryInfo.MoveTo #63675

merged 7 commits into from
Feb 8, 2022

Commits on Jan 12, 2022

  1. fix the tests: call the virtual Move method, which is overriden in Di… 

    …rectoryInfo_MoveTo class and allows for testing DirectoryInfo.MoveTo as well
    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b6ca0d9 View commit details
    Browse the repository at this point in the history

  2. unify the Directory.Move and DirectoryInfo.MoveTo logic, move the com… 

    …mon part to FileSystem.MoveDirectory
    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    43509b6 View commit details
    Browse the repository at this point in the history

  3. remove duplicated check

    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    896245d View commit details
    Browse the repository at this point in the history

  4. there is no need to perform the extra checks on Windows

    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    af1cd9b View commit details
    Browse the repository at this point in the history

  5. check for source file existience only once

    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    373a4a2 View commit details
    Browse the repository at this point in the history

  6. improve performance

    @adamsitnik
    adamsitnik committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    02a8664 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. on WASM rename does not fail with ENOTDIR for files that end with / 

    so we need to handle it before rename is called
    @adamsitnik
    adamsitnik committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    753e3d5 View commit details
    Browse the repository at this point in the history