-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw PNSE if insufficient privileges when custom Ping payload was specified #64625
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #62458 I had to refactor tests a bit since they depended on the fact that such invocation would not throw.
|
src/libraries/System.Net.Ping/src/System/Net/NetworkInformation/Ping.PingUtility.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
8ad0af7
to
d906962
Compare
d906962
to
68d3699
Compare
6933ad6
to
2ad4d51
Compare
Test failures are unrelated |
src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me.
I left comment about UsesPingUtility
that seems wrong.
CI Failures are unrelated (failed to upload to Helix) |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
Fixes #62458
I had to refactor tests a bit since they depended on the fact that such invocation would not throw.