Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run superpmi-replay pipeline on JIT PRs #66063

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Run superpmi-replay pipeline on JIT PRs #66063

merged 1 commit into from
Mar 10, 2022

Conversation

BruceForstall
Copy link
Member

Currently, the runtime-coreclr superpmi-replay pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.

@BruceForstall
Run superpmi-replay pipeline on JIT PRs
316a2fe 
Currently, the `runtime-coreclr superpmi-replay` pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 2, 2022
@ghost ghost assigned BruceForstall Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, the runtime-coreclr superpmi-replay pipeline is run
when a JIT change is merged. This change moves the checking to happen
on the PR pre-merge, as a requirement for merging.

Author: BruceForstall
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@BruceForstall
Copy link
Member Author

BruceForstall commented Mar 2, 2022 •
edited
Loading

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib

@kunalspathak
Copy link
Member

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

Are you planning to change this before merging this PR?

@kunalspathak
Copy link
Member

Currently, the superpmi-replay pipeline takes 3 hours. Seems like we should increase the Helix parallelism to reduce this time if we're going to run the pre-merge.

Are you planning to change this before merging this PR?

Never mind. Didn't see #66065

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib Now that #66065, this is ready to go, as long as we're willing to accept 1h40m time for a PR job. (I'm not sure how long our existing jobs take...)

@kunalspathak
Copy link
Member

I don't mind having this gate for JIT changes.

@BruceForstall
Copy link
Member Author

@dotnet/jit-contrib Any more opinions on this, and/or PR approval?

kunalspathak
kunalspathak approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was already merged and wondered couple of times why it didn't get triggered on my PRs. Now I know why. :)

@BruceForstall BruceForstall merged commit f1c298f into dotnet:main Mar 10, 2022
@BruceForstall BruceForstall deleted the SpmiReplayOnJitPullRequest branch March 10, 2022 01:01
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@BruceForstall BruceForstall

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @kunalspathak