Do not propagate RHS flags in block morphing #66291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsIt is not necessary to copy flags from the source node to the field nodes when doing a field-by-field copy in block morphing. In fact, it can be a pessimization in cases where the source node had NO_CSE set, which would block constant propagation. We're expecting broadly good diffs, with a couple size regressions due to said constant propagation not always being better.
|
|
@dotnet/jit-contrib |
It is not necessary to copy flags from the source node to the field nodes when doing a field-by-field copy in block morphing. In fact, it can be a pessimization in cases where the source node had NO_CSE set, which would block constant propagation.
SingleAccretion
force-pushed
the
No-No-CSE-Again
branch
from
6d9fed1
to
e0e9659
Compare
AndyAyersMS
approved these changes
Mar 9, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to copy flags from the source node to the field nodes when doing a field-by-field copy in block morphing. In fact, it can be a pessimization in cases where the source node had NO_CSE set, which would block constant propagation.
Broadly good diffs, with a couple size regressions due to said constant propagation not always being better.