Code fix to add DisableRuntimeMarshalling when required #67676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement code fix to provide the DisableRuntimeMarshalling attribute when a P/Invoke requires it. Update tool versions to get required bugfixes
…-marshalling-code-fix
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsImplement code fix to provide the DisableRuntimeMarshalling attribute when a P/Invoke requires it. Update tool versions to get required bugfixes
|
jkoritzinsky
requested review from
elinor-fung and
AaronRobinsonMSFT
and removed request for
AaronRobinsonMSFT
...pServices/gen/LibraryImportGenerator/Analyzers/AddDisableRuntimeMarshallingAttributeFixer.cs
Outdated
Show resolved
Hide resolved
...pServices/gen/LibraryImportGenerator/Analyzers/AddDisableRuntimeMarshallingAttributeFixer.cs
Show resolved
Hide resolved
...e.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/MarshallingGenerator.cs
Show resolved
Hide resolved
...es/tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs
Show resolved
Hide resolved
…-marshalling-code-fix
25 tasks
|
I'm seeing MethodAccessExceptions on Mono for these tests in the Roslyn SDK... I'll take a look, but I have a feeling that this is some deficiency in Mono with dynamic assemblies and it might be worth just disabling these new tests on Mono for now. cc @akoeplinger |
AaronRobinsonMSFT
approved these changes
Apr 12, 2022
This was referenced Apr 12, 2022
This was referenced Apr 12, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement code fix to provide the DisableRuntimeMarshalling attribute when a P/Invoke requires it.
Update tool versions to get required bugfixes