[DRAFT] Refactor marshaling code into legacy and non-legacy #68004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naricc
changed the title
lambdageek
reviewed
Apr 15, 2022
| @@ -91,8 +91,13 @@ set(metadata_common_sources | |||
| lock-tracer.h | |||
| marshal.c | |||
| marshal.h | |||
| marshal-legacy.c | |||
There was a problem hiding this comment.
I haven't started looking in detail yet, but I would have expected marshal-legacy.c to go into the ilgen_base_sources group (line 15-22)
There was a problem hiding this comment.
Ok, I will make that change. I don't think I need a detailed review yet. I put it in draft mode while I work out some things I only saw in CI, but it doesn't seem to let me take your off as a reviewer.
This was referenced Apr 25, 2022
|
Closed because this is missing some changes that are difficult to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in draft mode while I work out some build issues.
This PR refactors the marshallng code into legacy, non-legacy, and shared parts. This is one step in a change that will let move the legacy portion to a component. Once componentization is complete, the runtime size will be reduced by approxiamtely 100 KB (on x64) when the legacy component is not needed.
contributes to: #61685