-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Refactor marshaling code into legacy and non-legacy #68004
Closed
Closed
Changes from 11 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
9f27645
Split marshal into marshal, marshal-legacy.
naricc 61363c9
Factored shared parts into seperate file.
naricc b3b831c
Added legacy-noilgen
naricc cb0559b
Remove now redundant code from marshal-ilgen
naricc 3cefdfe
Added static
naricc ff951f3
Removed unused variable cb_inited
naricc 6364c30
Removed unused variable sh_dangerous_release
naricc 80d6a1d
Incorporated changes to mono_marshal_shared_conv_to_icall
naricc 2931ce0
Removed redundant copy of emit_object_to_ptr_conv
naricc e768c03
Removed redeclarations.
naricc f9d4ff3
Removed more redeclarations.
naricc 380c70c
Put #ifdef ENABLE_ILGEILGEN around mono_marshal_ilgen_legacy_init (void)
naricc 102a123
Removed copy for marshal-legacy.
naricc 03c4f5f
Added ifdef around mono_marshal_ilgen_legacy_init
naricc 629a3fa
Remvoed redundant emit_struct_conv.
naricc 197c567
Added back missing klass.
naricc 5d7f758
Added missing block.
naricc b4d6caa
Deleted unneed block.
naricc b827a54
Integrated change with indirect field access.
naricc 7670dc3
Updated emit_marshal_custom_ilgen
naricc 3dc2274
Removed redundant get_method_nofail
naricc 3e477f0
Removed more redundant code. Recopied emit_marshal_object_ilgen
naricc e9facc5
Recopied mono_marshal_shared_conv_to_icall
naricc 30eee10
Recopied emit_marshal_vtype_ilgen
naricc c9c4153
Recopied mono_marshal_shared_emit_struct_conv_full
naricc 111254a
Recopied mono_marshal_shared_emit_object_to_ptr_conv
naricc abaa746
Recopied emit_marshal_boolean_ilgen
naricc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't started looking in detail yet, but I would have expected marshal-legacy.c to go into the ilgen_base_sources group (line 15-22)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will make that change. I don't think I need a detailed review yet. I put it in draft mode while I work out some things I only saw in CI, but it doesn't seem to let me take your off as a reviewer.