Recognize the stateful marshaller shape #71355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for basic marshalling features with the stateful shapes (no optional feature tests yet).
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsAdd support for stateful marshallers. This PR includes support for the basic methods as well as This should get us enough support to be able to move ASP.NET Core over to the new model once we get the new API approved.
|
…try-point attributes separately. This allows us to disambiguate between the scenario where none of the marshallers from the scenario where none of the new attributes are used.
elinor-fung
reviewed
Jun 29, 2022
...time.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/MarshallerHelpers.cs
Show resolved
Hide resolved
...ies/System.Runtime.InteropServices/gen/Microsoft.Interop.SourceGeneration/MarshallerShape.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/tests/TestAssets/SharedTypes/NonBlittable.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Jun 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for stateful marshallers.
This PR includes support for the basic methods as well as
FreeandNotifyInvokeSucceededand caller allocated buffers. It does not include support for pinning yet.This should get us enough support to be able to move ASP.NET Core over to the new model once we get the new API approved.