Update to use CustomMarshaller entry point type #71398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests do not pass. Added TODOs for questions about behavior between new and old implementation.
elinor-fung
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsMostly @AaronRobinsonMSFT's work. Switch to the new proposal with Fair bit of cleanup/TODOs to address after this, but I'd rather get the basic model in, since other work will build on it.
|
ghost
assigned 
jkoritzinsky
approved these changes
Jun 28, 2022
|
Once this is in, I'll update the tests in #71355. |
AaronRobinsonMSFT
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly @AaronRobinsonMSFT's work.
Switch to the new proposal with
CustomMarshallerAttributeandScenarioenum for the entry point.Fair bit of cleanup/TODOs to address after this, but I'd rather get the basic model in, since other work will build on it.