Fix tar checksum calculation bug #72139
Conversation
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsCommit 1959b35: Fix tar checksum calculation bugI noticed that after rewriting some of the code to adapt it to the async methods, I accidentally added the final checksum instead of overriding it. I fixed it, and make sure to add a bunch of checksum calculation tests for different entry types and formats. Made sure to reuse as much code as possible in the tests. Commit 4200f2e: Rename TarEnrty test filesI noticed some test files had the original classnames with the format at the end (TarEntryGnu, TarEntryPax...). I renamed it to the official name we approved (GnuTarEnty, PaxTarEntry...). Commit 2016fbd: Merge await using declarations with usagesSome of the tests I submitted in the PR that implemented the Async methods, were still awaiting
|
src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.Write.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Commit 1959b35: Fix tar checksum calculation bug
I noticed that after rewriting some of the code to adapt it to the async methods, I accidentally added the final checksum instead of overriding it. I fixed it, and make sure to add a bunch of checksum calculation tests for different entry types and formats. Made sure to reuse as much code as possible in the tests.
Commit 4200f2e: Rename TarEnrty test files
I noticed some test files had the original classnames with the format at the end (TarEntryGnu, TarEntryPax...). I renamed it to the official name we approved (GnuTarEnty, PaxTarEntry...).
Commit 2016fbd: Merge await using declarations with usages
Some of the tests I submitted in the PR that implemented the Async methods, were still awaiting
IAsyncDisposableobjects in two lines. I just merged them into a single line.