Delete more verification code #72747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMostly just dead code, the only semantic change is around tailcall checks used for stress, they don't check type compatibility in the strict type system sense anymore. Contributes to #32648.
|
SingleAccretion
force-pushed
the
Delete-Dead-Verification-Code-Upstream
branch
2 times, most recently
from
bbf0466
to
f2a4221
Compare
SingleAccretion
force-pushed
the
Delete-Dead-Verification-Code-Upstream
branch
from
f2a4221
to
bcea870
Compare
|
@dotnet/jit-contrib |
We only use it for tail call stress.
SingleAccretion
force-pushed
the
Delete-Dead-Verification-Code-Upstream
branch
from
bcea870
to
8059243
Compare
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Old jistress logs are gone because of the pipeline shift. Let's bounce this and retrun. |
|
/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jakobbotsch
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just dead code, the only semantic change is around tailcall checks used for stress, they don't check type compatibility in the strict type system sense anymore.
Contributes to #32648.
No diffs (modulo a small TP win).