Fix argument validation in RuntimeType.InvokeMember #74998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rollout of `!!` erroneously moved an ArgumentNullException to be thrown earlier in the method, preventing a null name from being used (which is valid with BindingFlags.CreateInstance). (Separately, we should consider fixing the nullable reference type annotation on `string name`, since null is allowed in some circumstances.)
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsThe rollout of (Separately, we should consider fixing the nullable reference type annotation on Fixes #74977 (reply in thread)
|
AaronRobinsonMSFT
approved these changes
Sep 2, 2022
|
Thanks @stephentoub. I assume we can also get this into 7.0 once it is in 8.0? |
|
That's my plan. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2980567108 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rollout of
!!erroneously moved an ArgumentNullException to be thrown earlier in the method, preventing a null name from being used (which is valid with BindingFlags.CreateInstance).(Separately, we should consider fixing the nullable reference type annotation on
string name, since null is allowed in some circumstances.)Fixes #74977 (reply in thread)
cc: @AaronRobinsonMSFT, @steveharter