Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use normal VNs when adding NRE exception sets #76639

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Use normal VNs when adding NRE exception sets #76639

merged 1 commit into from
Oct 7, 2022

Conversation

SingleAccretion
Copy link
Contributor

Let's see what the diffs look like.

This should fix the very particular example from #76638.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 4, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 4, 2022
@ghost
Copy link

ghost commented Oct 4, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Let's see what the diffs look like.

This should fix the very particular example from #76638.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Oct 5, 2022
Closed
@SingleAccretion SingleAccretion marked this pull request as ready for review October 6, 2022 18:06
@SingleAccretion
Copy link
Contributor Author

Failures look known / not related.

Diffs are of the traditional kind we tend to see with more precise exception sets - more CSEing, not always a size win, and sometimes even a PerfScore loss, though not that often.

AndyAyersMS
AndyAyersMS approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Let's get this some bake time in main while we look for more evidence that it might be something we want to backport.

@AndyAyersMS
Copy link
Member

/azp run runtime-coreclr libraries-jitstress, runtime-coreclr jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AndyAyersMS
Copy link
Member

Coreclr jitstress failures are #76280.

Libraries jitstress failures seem to be there in the baseline runs too.

@AndyAyersMS AndyAyersMS merged commit 6367772 into dotnet:main Oct 7, 2022
@SingleAccretion SingleAccretion deleted the NormalVNs-In-Exc-Sets branch October 7, 2022 16:13
@AndyAyersMS AndyAyersMS mentioned this pull request Oct 22, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SingleAccretion @AndyAyersMS