[release/6.0] Always generate metadata for dynamic methods #77322
Conversation
tommcdon
added
Servicing-consider
|
Tagging subscribers to this area: @tommcdon Issue DetailsWe have had multiple customer and partner team reports of the following error in Visual Studio while attempting to attach to a .NET 6 process:
Customer and partner reports include: #69841, "The application is in break mode" despite hitting resolved breakpoint, and #62977 for examples. We have also had internal teams reach out to us via email encountering this problem. The root issue is described in #62977. This is an unintended side effect of #57069. As it stands now we won't generate metadata for dynamic modules unless a debugger is attached. Without the metadata, the .NET debugging services API is unable to walk the stack resulting in the error in VS shown above. Customer ImpactCustomers attaching to their process after a dynamic method has been created can trigger this error. We have seen this reproduce with Azure Functions as well as customers using Debug->Attach dialog in VS. RiskVery low as it restores the original behavior before #57069 for debugger metadata generation for dynamic methods. TestingThis fix is a backport of #72315 and has been manually tested/verified by internal partner teams with private 6.0 builds backporting this fix.
|
|
Verified the CI failure is not related to this change |
rbhanda
added
Servicing-approved
|
CI failure seems to be this unrelated problem: #74328 Approved by Tactics. Signed off. No OOB package authoring changes needed. Ready to merge. |
We have had multiple customer and partner team reports of the following error in Visual Studio while attempting to attach to a .NET 6 process:
Customer and partner reports include: #69841, "The application is in break mode" despite hitting resolved breakpoint, and #62977. We have also had internal teams reach out to us via email encountering this problem.
The root issue is described in #62977. This is an unintended side effect of #57069. As it stands now we won't generate metadata for dynamic modules unless a debugger is attached. Without the metadata, the .NET debugging services API is unable to walk the stack resulting in the error in VS shown above.
Customer Impact
Customers attaching to their process after a dynamic method has been created can trigger this error. We have seen this reproduce with F5 debugging on Azure Functions Visual Studio projects as well as customers using Debug->Attach dialog in VS.
Risk
Very low as it restores the original behavior before #57069 for debugger metadata generation for dynamic methods.
Testing
This fix is a backport of #72315 and has been manually tested/verified by internal partner teams with private 6.0 builds backporting this fix.