Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Always generate metadata for dynamic methods #77322

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[release/6.0] Always generate metadata for dynamic methods #77322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/coreclr/vm/ceeload.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12594,15 +12594,6 @@ void ReflectionModule::CaptureModuleMetaDataToMemory()
}
CONTRACTL_END;

// If a debugger is attached, then the CLR will still send ClassLoad notifications for dynamic modules,
// which mean we still need to keep the metadata available. This is the same as Whidbey.
// An alternative (and better) design would be to suppress ClassLoad notifications too, but then we'd
// need some way of sending a "catchup" notification to the debugger after we re-enable notifications.
if (!CORDebuggerAttached())
{
return;
}

// Do not release the emitter. This is a weak reference.
IMetaDataEmit *pEmitter = this->GetEmitter();
_ASSERTE(pEmitter != NULL);
Expand Down