Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Add warning code to all warnings produced in WasmAppBuilder #79234

Merged
merged 3 commits into from
Jan 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 5, 2022

Backport of #78755 to release/7.0

/cc @maraf

Customer Impact

Customers can disable individual warnings that can occur while building wasm applications.
Fixes customer reported issue #78690.

Testing

Manual.

Risk

Low. Only warning codes where added to existing warnings.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@maraf maraf added this to the 7.0.x milestone Dec 5, 2022
@maraf maraf added the arch-wasm WebAssembly architecture label Dec 5, 2022
@ghost
Copy link

ghost commented Dec 5, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #78755 to release/7.0

/cc @maraf

Customer Impact

Customers are able to disable indivial warnings that can occur while building wasm applications.
Fixes customer reported issue #78690.

Testing

Manual.

Risk

Low. The only change without additional configuration is that warning messages are prefixed with warning code.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: 7.0.x

@maraf maraf self-assigned this Dec 5, 2022
@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Dec 6, 2022
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.3 Dec 6, 2022
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 6, 2022
@carlossanlop
Copy link
Member

Approved by Tactics.
Signed off by area owner.
No OOB changes needed.
CI failure is known, unrelated, and has already been fixed in the branch: #78778
Waiting for the last question to be answered before merging.

@carlossanlop
Copy link
Member

Although there's still an additional question to answer in the conversation, it was marked as resolved, so I'll merge.

CI failure is known/unrelated/already fixed: #78778

@carlossanlop carlossanlop merged commit ff4cab3 into release/7.0 Jan 5, 2023
@carlossanlop carlossanlop deleted the backport/pr-78755-to-release/7.0 branch January 5, 2023 18:44
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants