Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Use MonoWasmBuildVariant to select runtime variant #80024

Merged
merged 1 commit into from Jan 5, 2023
Merged

[build] Use MonoWasmBuildVariant to select runtime variant #80024

merged 1 commit into from Jan 5, 2023

Conversation

lambdageek
Copy link
Member

Use MonoWasmBuildVariant=multithread and
MonoWasmBuildVariant=perftrace consistently to select the runtime variant. Previously we also supported setting WasmEnableThreads or WasmEnablePerfTracing to configure the runtime variant. This PR removes support for that.

Note that this is distinct from what users do: the public WasmEnableThreads (respectively, WasmEnablePerfTracing) property are used in user project to choose the threaded (respectively, diagnostic tracing) runtime pack in a user project. That support is not going way in this PR.

The only tricky bit is that when building and testing the sample projects, we need to set the public properties, not the wasm build variant property.

Fixes #75152

@ghost ghost assigned lambdageek Dec 28, 2022
@lambdageek lambdageek added the arch-wasm WebAssembly architecture label Dec 28, 2022
@ghost
Copy link

ghost commented Dec 28, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Use MonoWasmBuildVariant=multithread and
MonoWasmBuildVariant=perftrace consistently to select the runtime variant. Previously we also supported setting WasmEnableThreads or WasmEnablePerfTracing to configure the runtime variant. This PR removes support for that.

Note that this is distinct from what users do: the public WasmEnableThreads (respectively, WasmEnablePerfTracing) property are used in user project to choose the threaded (respectively, diagnostic tracing) runtime pack in a user project. That support is not going way in this PR.

The only tricky bit is that when building and testing the sample projects, we need to set the public properties, not the wasm build variant property.

Fixes #75152

Author: lambdageek
Assignees: lambdageek
Labels:

arch-wasm, area-Build-mono
Milestone: -

@lambdageek
Copy link
Member Author

/cc @steveisok @akoeplinger

@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 28, 2022
Closed
Closed
@lewing lewing requested a review from maraf January 4, 2023 17:56
maraf
maraf approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

I'm just thinking whether MonoWasmRuntimeVariant wouldn't be a better name?

src/mono/wasm/wasm.proj Show resolved Hide resolved
@lambdageek
Copy link
Member Author

I'm just thinking whether MonoWasmRuntimeVariant wouldn't be a better name?

We can consider changing in a follow-up PR. (MonoWasmBuildVariant isn't a new thing in this PR - it's already used in various places.)

@lambdageek
Copy link
Member Author

I'm going to pick up the changes in main and rerun CI and then merge. want to verify those LibraryTests_AOT lanes are all good

@lambdageek
[build] Use MonoWasmBuildVariant to select runtime variant
ebd2ba7 
Use `MonoWasmBuildVariant=multithread` and
`MonoWasmBuildVariant=perftrace` consistently to select the runtime
variant.  Previously we also supported setting `WasmEnableThreads` or
`WasmEnablePerfTracing` to configure the runtime variant.  This PR
removes support for that.

Note that this is distinct from what users do: the public
`WasmEnableThreads` (respectively, `WasmEnablePerfTracing`) property
are used in user project to choose the threaded (respectively,
diagnostic tracing) runtime pack in a user project.  That support is
not going way in this PR.

The only tricky bit is that when building and testing the sample
projects, we need to set the public properties, not the wasm build
variant property.

Fixes dotnet#75152
@lambdageek lambdageek force-pushed the prefer-WasmBuildVariant-over-WasmEnable branch from bc8b531 to ebd2ba7 Compare January 5, 2023 18:40
@lambdageek
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek lambdageek merged commit 92d7381 into dotnet:main Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@lambdageek lambdageek

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm-mt] Settle on MonoWasmBuildVariant to control build variants
2 participants
@lambdageek @maraf