Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm-mt] Settle on MonoWasmBuildVariant to control build variants #75152

Closed
lambdageek opened this issue Sep 6, 2022 · 3 comments · Fixed by #80024
Closed

[wasm-mt] Settle on MonoWasmBuildVariant to control build variants #75152

lambdageek opened this issue Sep 6, 2022 · 3 comments · Fixed by #80024
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
8.0.0

Comments

@lambdageek
Copy link
Member

lambdageek commented Sep 6, 2022 •
edited
Loading

Instead of WasmEnableThreads=true (resp WasmEnablePerfTracing=true) just use MonoWasmBuildVariant=multithread (resp MonoWasmBuildVariant=perftrace) everywhere. I'm not sure why we need two mechanisms for doing the same thing.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 6, 2022
@lambdageek lambdageek added arch-wasm WebAssembly architecture area-Build-mono labels Sep 6, 2022
@lambdageek lambdageek added this to the 8.0.0 milestone Sep 6, 2022
@ghost
Copy link

ghost commented Sep 6, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Instead of WasmEnableThreads=true (resp WasmEnablePerfTracing=true) just use MonoWasmBuildVariant=multithread (resp MonoWasmBuildVariant=perftrace everywhere). I'm not sure why we need two mechanisms for doing the same thing.

Author: lambdageek
Assignees: -
Labels:

arch-wasm, untriaged, area-Build-mono
Milestone: -

@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 6, 2022
@lambdageek
Copy link
Member Author

We should hold off on this until net7 is done. There's value in being able to backport from main to release/7.0 right now

@lambdageek lambdageek mentioned this issue Dec 28, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 28, 2022
lambdageek added a commit to lambdageek/runtime that referenced this issue Jan 5, 2023
@lambdageek
[build] Use MonoWasmBuildVariant to select runtime variant
ebd2ba7 
Use `MonoWasmBuildVariant=multithread` and
`MonoWasmBuildVariant=perftrace` consistently to select the runtime
variant.  Previously we also supported setting `WasmEnableThreads` or
`WasmEnablePerfTracing` to configure the runtime variant.  This PR
removes support for that.

Note that this is distinct from what users do: the public
`WasmEnableThreads` (respectively, `WasmEnablePerfTracing`) property
are used in user project to choose the threaded (respectively,
diagnostic tracing) runtime pack in a user project.  That support is
not going way in this PR.

The only tricky bit is that when building and testing the sample
projects, we need to set the public properties, not the wasm build
variant property.

Fixes dotnet#75152
lambdageek added a commit that referenced this issue Jan 5, 2023
@lambdageek
[build] Use MonoWasmBuildVariant to select runtime variant (#80024)
92d7381 
Use `MonoWasmBuildVariant=multithread` and
`MonoWasmBuildVariant=perftrace` consistently to select the runtime
variant.  Previously we also supported setting `WasmEnableThreads` or
`WasmEnablePerfTracing` to configure the runtime variant.  This PR
removes support for that.

Note that this is distinct from what users do: the public
`WasmEnableThreads` (respectively, `WasmEnablePerfTracing`) property
are used in user project to choose the threaded (respectively,
diagnostic tracing) runtime pack in a user project.  That support is
not going way in this PR.

The only tricky bit is that when building and testing the sample
projects, we need to set the public properties, not the wasm build
variant property.

Fixes #75152
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[build] Use MonoWasmBuildVariant to select runtime variant lambdageek/runtime
1 participant
@lambdageek