Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [Android] Fix path to ping on Android API 21-27 #80121

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2023

Backport of #79076 to release/6.0

/cc @simonrozsival

Customer Impact

This issue affects only a subset of customers on older Android versions. The System.Net.NetworkInformation.Ping class didn't work in apps running on these systems.

Testing

Tested locally on Android emulators with APIs 21-27.

Risk

Low.

@ghost
Copy link

ghost commented Jan 3, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79076 to release/6.0

/cc @simonrozsival

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net

Milestone: -

@ghost
Copy link

ghost commented Jan 3, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79076 to release/6.0

/cc @simonrozsival

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net, os-android

Milestone: -

@carlossanlop
Copy link
Member

carlossanlop commented Jan 5, 2023

@simonrozsival when this is ready, please add the servicing-consider label and send an email to Tactics requesting approval.

Can you also please verify if the CI failures are related or not?

@steveisok steveisok added the Servicing-consider Issue for next servicing release review label Jan 11, 2023
@carlossanlop
Copy link
Member

@simonrozsival have you sent the email to Tactics requesting approval? I can't find it.

Friday Jan 13th EOD is the cut-off date for Code Complete for the February release. We want to try to merge all backports in advance so that we have time to monitor the base branch for any unexpected breaks. Reminder that next weekend is a long weekend (Monday is a holiday in the US).

@simonrozsival simonrozsival added this to the 6.0.x milestone Jan 12, 2023
@simonrozsival
Copy link
Member

@carlossanlop I've sent the email today.

CI failures are unrelated to this PR (#80029, #79858, #78778)

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 12, 2023
@leecow leecow modified the milestones: 6.0.x, 6.0.14 Jan 12, 2023
@carlossanlop
Copy link
Member

Approved by Tactics (6.0.14).
Signed off by area owner.
No OOB changes needed (Android code).
CI failures investigated, they're unrelated.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit f72b2b8 into release/6.0 Jan 12, 2023
@carlossanlop carlossanlop deleted the backport/pr-79076-to-release/6.0 branch January 12, 2023 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants