Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alloc/dealloc mismatches and some buffer overruns found by ASAN #80189

Merged
merged 3 commits into from Jan 7, 2023
Merged

Fix alloc/dealloc mismatches and some buffer overruns found by ASAN #80189

merged 3 commits into from Jan 7, 2023

Conversation

jkoritzinsky
Copy link
Member

Fix an alloc-dealloc mismatch in ThreadLocalModule and fix some alloc-dealloc mismatches and buffer overruns in ilasm.

Extracted from https://github.com/dotnet/runtime/pull/74623/commits

@ghost ghost assigned jkoritzinsky Jan 4, 2023
janvorli
janvorli approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jkoritzinsky jkoritzinsky merged commit cebd09a into dotnet:main Jan 7, 2023
@jkoritzinsky jkoritzinsky deleted the asan-fixes branch January 7, 2023 02:04
@dotnet dotnet locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkoritzinsky @janvorli