JIT: Account for GT_JMP implicit uses in local morph ref counting #80734
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak |
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
|
Let me see if I can do something for the MinOpts TP regression. |
src/coreclr/jit/lclmorph.cpp
Outdated
| case GT_LCL_FLD: | ||
| MorphLocalField(node, user); | ||
| assert(node->OperIsLocal()); | ||
| __fallthrough; |
There was a problem hiding this comment.
| __fallthrough; | |
| FALLTHROUGH; |
(We use the macro version everywhere else)
There was a problem hiding this comment.
I ended up reverting this because the case above also can potentially morph to a local, so also needs some more handling. There is a BasicBlock helper already to check for GT_JMP that it uses now.
There was a problem hiding this comment.
Just for my understanding: why not use compJmpOpUsed?
(Multiple JMPs?)
There was a problem hiding this comment.
Yes (BasicBlock::endsWithJmpMethod does use compJmpOpUsed as an early-out)
|
One diff in the test that exposed the problem -- we no longer incorrectly omit a copy there. |
Fix #80731
Found by #80691.