Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we specify arguments only when the test ask for it #80947

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Jan 20, 2023

In the reliability framework test, we use reflection to invoke the main method.

There are some test cases where the string[] argument is absent in the main method, and therefore the reflection call will fail.

This change detects the situation and make sure we supply the right number of arguments to the reflection call.

@ghost ghost assigned cshung Jan 20, 2023
@cshung cshung marked this pull request as draft January 20, 2023 19:43
@ghost
Copy link

ghost commented Jan 20, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

Copy link
Contributor

@PeterSolMS PeterSolMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cshung cshung marked this pull request as ready for review January 27, 2023 20:09
@cshung cshung merged commit ce9c269 into dotnet:main Jan 27, 2023
@cshung cshung deleted the public/fix-param-count branch January 27, 2023 20:10
@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants