[main] Update dependencies from dotnet/roslyn #81164

dotnet-maestro · 2023-01-25T13:54:02Z

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
Build: 20230220.1
Date Produced: February 20, 2023 10:43:44 AM UTC
Commit: 4190056e0126f206c64439275fbf43a54dd31067
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.6.0-1.23073.4 to 4.6.0-2.23120.1
- Microsoft.CodeAnalysis.CSharp: from 4.6.0-1.23073.4 to 4.6.0-2.23120.1
- Microsoft.Net.Compilers.Toolset: from 4.6.0-1.23073.4 to 4.6.0-2.23120.1

…124.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23074.5

lewing · 2023-01-25T23:47:16Z

src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/AddDisableRuntimeMarshallingAttributeFixerTests.cs(145,22): error RS1036: (NETCORE_ENGINEERING_TELEMETRY=Build) 'LibraryImportGenerator.UnitTests.AddDisableRuntimeMarshallingAttributeFixerTests.MockAnalyzer': A project containing analyzers or source generators should specify the property '<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>' with the new roslyn

ghost · 2023-01-25T23:47:58Z

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
Build: 20230124.5
Date Produced: January 25, 2023 4:51:37 AM UTC
Commit: 234e15d0b7b74ad1119612ed214939928b5b4aea
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.6.0-1.23073.4 to 4.6.0-1.23074.5
- Microsoft.CodeAnalysis.CSharp: from 4.6.0-1.23073.4 to 4.6.0-1.23074.5
- Microsoft.Net.Compilers.Toolset: from 4.6.0-1.23073.4 to 4.6.0-1.23074.5

Author:	dotnet-maestro[bot]
Assignees:	-
Labels:	`area-System.Runtime.InteropServices`, `area-codeflow`
Milestone:	-

jkoritzinsky · 2023-01-25T23:50:28Z

We can disable that diagnostic for that assembly. The analayzer there isn't shipping and is only to work around some limitations in the unit testing system.

…126.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23076.1

…proj with reason.

ghost · 2023-01-26T23:37:57Z

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
Build: 20230126.1
Date Produced: January 26, 2023 10:00:14 AM UTC
Commit: fe8f333ce7eac33aec8dd87fd1fc54d23e65b141
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.6.0-1.23073.4 to 4.6.0-1.23076.1
- Microsoft.CodeAnalysis.CSharp: from 4.6.0-1.23073.4 to 4.6.0-1.23076.1
- Microsoft.Net.Compilers.Toolset: from 4.6.0-1.23073.4 to 4.6.0-1.23076.1

Author:	dotnet-maestro[bot]
Assignees:	-
Labels:	`area-codeflow`, `area-Tools-ILLink`
Milestone:	-

lewing · 2023-01-26T23:40:46Z

src/tools/illink/src/ILLink.CodeFix/UnconditionalSuppressMessageCodeFixProvider.cs(47,58): error RS1035: (NETCORE_ENGINEERING_TELEMETRY=Build) The symbol 'CultureInfo.CurrentUICulture' is banned for use by analyzers: Analyzers should use the locale given by the compiler command line arguments, not the CurrentUICulture I'm not clear if this one is genuine or should be suppressed. cc @vitek-karas @sbomer

jkoritzinsky · 2023-01-27T00:17:22Z

I asked @RikkiGibson how best to fix that diagnostic as I can't figure out the right API to use to get to the command line arguments. In the meantime, it's probably okay to suppress, just not the best. That one I'd suppress at the use-site.

…127.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23077.1

…127.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23077.8

…128.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23078.5

…129.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23079.1

…131.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23081.1

…131.23 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23081.23

EgorBo · 2023-02-01T17:18:07Z

So this is currently blocked on Roslyn folks to address dotnet/roslyn#66566 or we can ignore the warning untill it's fixed and land this?

…201.22 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23101.22

jkoritzinsky · 2023-02-02T16:43:28Z

@EgorBo yes, that is correct.

…202.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23102.6

…203.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23103.10

…204.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23104.1

I created dotnet/linker#3197 to track the removal of this once we can.

…214.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23114.7

ghost · 2023-02-15T17:41:02Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

Subscription: 0af788c4-77ba-425c-b8c9-08da91234a73
Build: 20230214.7
Date Produced: February 15, 2023 3:14:48 AM UTC
Commit: 12105175705e16f905dd1ec1fe8f7cff07ab8ba0
Branch: refs/heads/main

Updates:
- Microsoft.CodeAnalysis: from 4.6.0-1.23073.4 to 4.6.0-2.23114.7
- Microsoft.CodeAnalysis.CSharp: from 4.6.0-1.23073.4 to 4.6.0-2.23114.7
- Microsoft.Net.Compilers.Toolset: from 4.6.0-1.23073.4 to 4.6.0-2.23114.7

Author:	dotnet-maestro[bot]
Assignees:	-
Labels:	`area-System.Text.Json`, `area-codeflow`
Milestone:	-

lewing · 2023-02-15T17:54:50Z

Has someone opened a roslyn issue for this?

lewing · 2023-02-15T18:47:07Z

dotnet/roslyn#66900

…215.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23115.9

…216.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23116.4

…217.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23117.4

…218.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23118.2

...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs

…220.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23120.1

EgorBo · 2023-02-21T08:24:58Z

🎉

This reverts commit bbbc73e.

Reverts version bump component of #81164 This PR caused heavy managed build regressions hitting all PR builds. See #82458 and #76454

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com> Co-authored-by: vitek-karas <10670590+vitek-karas@users.noreply.github.com> Co-authored-by: pavelsavara <pavel.savara@gmail.com> Co-authored-by: Marek Safar <marek.safar@gmail.com>

Update dependencies from https://github.com/dotnet/roslyn build 20230…

1cf30c6

…124.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23074.5

dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Jan 25, 2023

build-analysis bot mentioned this pull request Jan 25, 2023

Tracking issue for CI build timeouts #76454

Closed

lewing requested a review from jkoritzinsky January 25, 2023 23:47

lewing added the area-System.Runtime.InteropServices label Jan 25, 2023

dotnet-maestro bot and others added 2 commits January 26, 2023 13:48

Update dependencies from https://github.com/dotnet/roslyn build 20230…

3b0acbc

…126.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23076.1

Disable extraneous diagnostic on LibraryImportGenerator.Unit.Tests.cs…

f6e5a4c

…proj with reason.

lewing added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed area-System.Runtime.InteropServices labels Jan 26, 2023

jkoritzinsky mentioned this pull request Jan 27, 2023

CultureInfo.CurrentCulture API banned in Analyzers but alternative API is inaccessible dotnet/roslyn#66566

Open

build-analysis bot mentioned this pull request Jan 27, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

dotnet-maestro bot added 6 commits January 27, 2023 13:52

Update dependencies from https://github.com/dotnet/roslyn build 20230…

8033eff

…127.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23077.1

Update dependencies from https://github.com/dotnet/roslyn build 20230…

4913d3b

…127.8 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23077.8

Update dependencies from https://github.com/dotnet/roslyn build 20230…

0881f0b

…128.5 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23078.5

Update dependencies from https://github.com/dotnet/roslyn build 20230…

b40b581

…129.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-1.23079.1

Update dependencies from https://github.com/dotnet/roslyn build 20230…

c67aa9d

…131.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23081.1

Update dependencies from https://github.com/dotnet/roslyn build 20230…

6c2f542

…131.23 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23081.23

Update dependencies from https://github.com/dotnet/roslyn build 20230…

ce0e2c7

…201.22 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23101.22

dotnet-maestro bot and others added 4 commits February 3, 2023 13:53

Update dependencies from https://github.com/dotnet/roslyn build 20230…

6177d27

…202.6 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23102.6

Update dependencies from https://github.com/dotnet/roslyn build 20230…

b91c4f0

…203.10 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23103.10

Update dependencies from https://github.com/dotnet/roslyn build 20230…

4781d51

…204.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23104.1

Suppress warning for code fixer

51cb171

I created dotnet/linker#3197 to track the removal of this once we can.

Update dependencies from https://github.com/dotnet/roslyn build 20230…

3328fda

…214.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23114.7

lewing added the area-System.Text.Json label Feb 15, 2023

lewing mentioned this pull request Feb 15, 2023

flow into dotnet/runtime main blocked dotnet/roslyn#66900

Closed

dotnet-maestro bot and others added 3 commits February 16, 2023 13:43

Update dependencies from https://github.com/dotnet/roslyn build 20230…

ff2d719

…215.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23115.9

Update TestClasses.Constructor.cs

9534241

Update dependencies from https://github.com/dotnet/roslyn build 20230…

93ae7b5

…216.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23116.4

build-analysis bot mentioned this pull request Feb 17, 2023

OSX infra issue - prereq check for 'pkg-config' missing #82240

Closed

dotnet-maestro bot added 2 commits February 18, 2023 13:38

Update dependencies from https://github.com/dotnet/roslyn build 20230…

3aab662

…217.4 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23117.4

Update dependencies from https://github.com/dotnet/roslyn build 20230…

67ade48

…218.2 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23118.2

build-analysis bot mentioned this pull request Feb 19, 2023

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

2 tasks

lewing added the blocked Issue/PR is blocked on something - see comments label Feb 20, 2023

marek-safar force-pushed the darc-main-5410199c-3511-41c9-8178-d0c10ae042d9 branch from 01e53a2 to 6283b2e Compare February 20, 2023 09:49

Update TestClasses.Constructor.cs

9c6c227

marek-safar force-pushed the darc-main-5410199c-3511-41c9-8178-d0c10ae042d9 branch from 6283b2e to 9c6c227 Compare February 20, 2023 10:50

eiriktsarpalis reviewed Feb 20, 2023

View reviewed changes

...braries/System.Text.Json/tests/Common/ConstructorTests/ConstructorTests.ParameterMatching.cs Outdated Show resolved Hide resolved

dotnet-maestro bot and others added 2 commits February 20, 2023 13:30

Update dependencies from https://github.com/dotnet/roslyn build 20230…

f849926

…220.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.6.0-1.23073.4 -> To Version 4.6.0-2.23120.1

Add tracking issue

bd745e8

marek-safar merged commit bbbc73e into main Feb 21, 2023

marek-safar deleted the darc-main-5410199c-3511-41c9-8178-d0c10ae042d9 branch February 21, 2023 08:13

hoyosjs mentioned this pull request Feb 22, 2023

Library and Tools Subset build times regression (50+% increase) #82583

Closed

hoyosjs added a commit that referenced this pull request Feb 22, 2023

Revert "[main] Update dependencies from dotnet/roslyn (#81164)"

ff0bd7c

This reverts commit bbbc73e.

hoyosjs mentioned this pull request Feb 22, 2023

Revert "[main] Update dependencies from dotnet/roslyn" #82466

Merged

hoyosjs added a commit that referenced this pull request Feb 22, 2023

Revert update dependencies from dotnet/roslyn (#82466)

98bf267

Reverts version bump component of #81164 This PR caused heavy managed build regressions hitting all PR builds. See #82458 and #76454

dotnet locked as resolved and limited conversation to collaborators Mar 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Update dependencies from dotnet/roslyn #81164

[main] Update dependencies from dotnet/roslyn #81164

dotnet-maestro bot commented Jan 25, 2023 •

edited

lewing commented Jan 25, 2023

ghost commented Jan 25, 2023

From https://github.com/dotnet/roslyn

jkoritzinsky commented Jan 25, 2023

ghost commented Jan 26, 2023

From https://github.com/dotnet/roslyn

lewing commented Jan 26, 2023

jkoritzinsky commented Jan 27, 2023

EgorBo commented Feb 1, 2023

jkoritzinsky commented Feb 2, 2023

ghost commented Feb 15, 2023

From https://github.com/dotnet/roslyn

lewing commented Feb 15, 2023

lewing commented Feb 15, 2023

EgorBo commented Feb 21, 2023

[main] Update dependencies from dotnet/roslyn #81164

[main] Update dependencies from dotnet/roslyn #81164

Conversation

dotnet-maestro bot commented Jan 25, 2023 • edited

From https://github.com/dotnet/roslyn

lewing commented Jan 25, 2023

ghost commented Jan 25, 2023

From https://github.com/dotnet/roslyn

jkoritzinsky commented Jan 25, 2023

ghost commented Jan 26, 2023

From https://github.com/dotnet/roslyn

lewing commented Jan 26, 2023

jkoritzinsky commented Jan 27, 2023

EgorBo commented Feb 1, 2023

jkoritzinsky commented Feb 2, 2023

ghost commented Feb 15, 2023

From https://github.com/dotnet/roslyn

lewing commented Feb 15, 2023

lewing commented Feb 15, 2023

EgorBo commented Feb 21, 2023

dotnet-maestro bot commented Jan 25, 2023 •

edited