-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] Update heap hard limit for large pages #81292
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #73508 to release/7.0 /cc @cshung Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 7.0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Backport of #73508 to release/7.0
/cc @cshung
Customer Impact
For a customer using both large pages and
clrgc
(i.e. segments), it is possible that some of our calculations will lead to failing to initialize the GC and thus failing to startup.Testing
The fix is applied on top of the customer's repro and we confirmed that it fixes the startup issue.
Risk
This is only applied under large pages and using segments, so the risk is low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.