[wasm] Enable jiterpreter traces; fix floating point compares #81417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
NO-MERGE
ghost
assigned 
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThis PR enables jiterpreter traces. I've got stats enabled right now as well so they'll be in the log for any failed tests on CI, will take that out before merging.
|
kg
requested review from
lewing,
pavelsavara,
vargaz,
lambdageek,
BrzVlad and
kotlarmilos
as code owners
kg
removed
the
NO-MERGE
|
Tests all passed, so disabling stats again |
lewing
approved these changes
Jan 31, 2023
kg
changed the title
vargaz
approved these changes
Jan 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables jiterpreter traces and fixes a bug in the implementation of floating point compares / floating point branches.