Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exceptions to TAR extended attribute constructors to disallow '=' and '\n' characters in keys and values. #82812

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Add exceptions to TAR extended attribute constructors to disallow '=' and '\n' characters in keys and values. #82812

merged 5 commits into from
Apr 24, 2023

Commits on Apr 4, 2023

  1. Prevent adding extended attribute keys containing '=', '\n', or value… 

    …s containing '\n'.
    @carlossanlop
    carlossanlop committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b4421a6 View commit details
    Browse the repository at this point in the history

  2. Add tests to verify that the PaxTarEntry and PaxGlobalExtendedAttribu… 

    …tesTarEntry constructors that take an extended attributes dictionary, throw when a disallowed character is found.
    @carlossanlop
    carlossanlop committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    5cd8c1f View commit details
    Browse the repository at this point in the history

  3. Apply CR suggestions

    @carlossanlop
    carlossanlop committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d690c9e View commit details
    Browse the repository at this point in the history

  4. Use enumerator to iterate items in the specified enumeration, and ins… 

    …ert them to the lazily created dictionary if they pass the validations.
    @carlossanlop
    carlossanlop committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    a6ca6ae View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Change IndexOf with Contains

    @carlossanlop
    carlossanlop committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    b247618 View commit details
    Browse the repository at this point in the history