Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nuget.projectmodel to version.details #86650

Merged

Conversation

oleksandr-didyk
Copy link
Contributor

Contributes to dotnet/source-build#3043

Declaring the Nuget.ProjectModel dependency in Version.Details.xml will allow source-build to replace the currently used 6.2.2 version with the n-1 version coming from previously source-built artifacts in the product / VMR build.

Without this change, once repo PvP is enabled for runtime, Nuget.ProjectModel will be marked as a pre-built.

@ghost
Copy link

ghost commented May 23, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to dotnet/source-build#3043

Declaring the Nuget.ProjectModel dependency in Version.Details.xml will allow source-build to replace the currently used 6.2.2 version with the n-1 version coming from previously source-built artifacts in the product / VMR build.

Without this change, once repo PvP is enabled for runtime, Nuget.ProjectModel will be marked as a pre-built.

Author: oleksandr-didyk
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

Interesting. I don't know enough about this so I would like to defer to @MichaelSimons and @mmitche

@oleksandr-didyk oleksandr-didyk merged commit b114416 into dotnet:main May 24, 2023
19 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants