Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection literal support for immutable collections #88470

Merged
merged 3 commits into from Jul 17, 2023

Conversation

stephentoub
Copy link
Member

Add the CollectionBuilderAttribute and use it on the supported immutable collections

Fixes #87569

Add the CollectionBuilderAttribute and use it on the supported immutable collections
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned stephentoub Jul 6, 2023
@ghost
Copy link

ghost commented Jul 6, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

Add the CollectionBuilderAttribute and use it on the supported immutable collections

Fixes #87569

Author: stephentoub
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation

Milestone: -

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, guess it's still pending API approval though?

@CyrusNajmabadi
Copy link
Member

Any interest in annotating the immutable interfaces at the same time?

@stephentoub stephentoub merged commit ec025ad into dotnet:main Jul 17, 2023
166 checks passed
@stephentoub stephentoub deleted the immutablecollectionsbuilder branch July 17, 2023 20:31
@dotnet dotnet locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: BCL additions to support C# 12's "Collection Literals" feature.
5 participants