Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Explicitly set dotnet root when building tools #88801

Merged
merged 4 commits into from Jul 13, 2023
Merged

[PERF] Explicitly set dotnet root when building tools #88801

merged 4 commits into from Jul 13, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Jul 12, 2023 •
edited

@LoopedBard3 LoopedBard3 self-assigned this Jul 12, 2023
@ghost
Copy link

ghost commented Jul 12, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Runtime update to go along with: dotnet/performance#3137.
Fixes: dotnet/performance#3136.
Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2220593&view=results

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure
Milestone: -

@LoopedBard3 LoopedBard3 marked this pull request as ready for review July 13, 2023 04:56
This was referenced Jul 13, 2023
Closed
Closed
cincuranet
cincuranet approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@cincuranet cincuranet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (minus what was commented out for testing).

kotlarmilos
kotlarmilos approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@kotlarmilos kotlarmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to revert the temporary changes.

LGTM!

@LoopedBard3
Revert "Setup testing."
a1c57f6 
This reverts commit 1ec7e4f.
@LoopedBard3
Copy link
Member Author

Reverted the temp changes, merging.

@LoopedBard3 LoopedBard3 merged commit 58cd4d2 into dotnet:main Jul 13, 2023
8 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfExplicitlySetDotnetRootWhenBuildingTools branch July 13, 2023 16:31
This was referenced Jul 13, 2023
Closed
Closed
Closed
@LoopedBard3 LoopedBard3 mentioned this pull request Jul 18, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@cincuranet cincuranet cincuranet approved these changes

@kotlarmilos kotlarmilos kotlarmilos approved these changes

@DrewScoggins DrewScoggins Awaiting requested review from DrewScoggins

@caaavik-msft caaavik-msft Awaiting requested review from caaavik-msft

Assignees

@LoopedBard3 LoopedBard3

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows pipelines failing to build tools
4 participants
@LoopedBard3 @radical @cincuranet @kotlarmilos