Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Use script instead of powershell to set DOTNET_ROOT #89123

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented Jul 18, 2023

Use script instead of powershell when we set pipeline variables in set DOTNET_ROOT as the Crossgen image used does not have pwsh. Follow-up to #88801

@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Use script instead of powershell so we can set the variable on all systems. (Crossgen image is missing pwsh).

Test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2224620&view=results

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3 LoopedBard3 changed the title Use script instead of powershell to set DOTNET_ROOT [PERF] Use script instead of powershell to set DOTNET_ROOT Jul 18, 2023
@LoopedBard3
Copy link
Member Author

This reverts commit 41fb0d3.
@LoopedBard3
Copy link
Member Author

Failures are unrelated, merging

@LoopedBard3 LoopedBard3 merged commit cf1482c into dotnet:main Jul 19, 2023
80 of 91 checks passed
@LoopedBard3 LoopedBard3 deleted the PerfUseScriptForSetDotnetRoot branch July 19, 2023 17:02
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants