NativeAOT createdump fork/exec for crash dump generation #89203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
mikem8361
force-pushed
the
createdumpexec
branch
from
74cafcf
to
4222f5a
Compare
hoyosjs
reviewed
Jul 21, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs
Outdated
Show resolved
Hide resolved
hoyosjs
reviewed
Jul 21, 2023
mikem8361
force-pushed
the
createdumpexec
branch
from
e71e894
to
82b5fe2
Compare
Port the .NET Core createdump fork/exec code to NativeAOT. Add src/native/inc/generatedumpflags.h. Remove dup definitions of this enum. Move and port clrconfignocache.h from src/coreclr/inc to src/native/inc/.
Fix some build problems.
Add PalCreateDump.h with all the public functions.
…dows. The next step is to pass the address of it to createdump.
Contains the exception record address for Native AOT crashes.
mikem8361
force-pushed
the
createdumpexec
branch
from
82b5fe2
to
9c88787
Compare
|
This is ready for the final review. Push the last changes (other than more review feedback). |
|
ping |
AaronRobinsonMSFT
approved these changes
Jul 27, 2023
|
I would like someone from the Native AOT team to make sure everything is ok. |
hoyosjs
reviewed
Jul 27, 2023
src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs
Show resolved
Hide resolved
hoyosjs
approved these changes
Jul 28, 2023
| @@ -22,6 +22,7 @@ CrashInfo::CrashInfo(const CreateDumpOptions& options) : | |||
| m_gatherFrames(options.CrashReport), | |||
| m_crashThread(options.CrashThread), | |||
| m_signal(options.Signal), | |||
| m_exceptionRecord(options.ExceptionRecord), | |||
There was a problem hiding this comment.
Perhaps this should be m_exceptionRecordAddr
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the .NET Core createdump fork/exec code to NativeAOT.
Add src/native/inc/generatedumpflags.h. Remove dup definitions of this enum.
Move and port clrconfignocache.h from src/coreclr/inc to src/native/inc (added the "inc" directory to native).
Is the clrconfignocache.h ok in src/native/inc? It being C++ code.
Should I move PalCreateDump.cpp from the src/coreclr/native/Runtime dir to src/native and do the work now in the .NET Core PAL to use this (mostly) common code?